rohityadavcloud commented on code in PR #9955:
URL: https://github.com/apache/cloudstack/pull/9955#discussion_r1978579657
##########
engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java:
##########
@@ -486,6 +488,39 @@ public void check() {
}
}
+ private void initDistributedLock() {
+ LOGGER.info("Setting up distributed lock table if not created.");
+ TransactionLegacy txn = TransactionLegacy.open("initDistributedLock");
+ txn.start();
+ String errorMessage = "Unable to get the database connections";
+ try {
+ Connection conn = txn.getConnection();
+ errorMessage = "Unable to create distributed_lock table in the
'cloud' database ";
+ String sql = "CREATE TABLE IF NOT EXISTS
`cloud`.`distributed_lock` (" +
+ " `name` varchar(1024) NOT NULL," +
+ " `thread` varchar(1024) NOT NULL," +
+ " `ms_id` bigint NOT NULL, `pid` int NOT NULL," +
+ " `created` datetime DEFAULT NULL," +
+ " PRIMARY KEY (`name`)," +
+ " UNIQUE KEY `name` (`name`)" +
+ ") ENGINE=InnoDB DEFAULT CHARSET=utf8";
+ try (PreparedStatement pstmt = conn.prepareStatement(sql)) {
+ pstmt.execute();
+ }
+ try (PreparedStatement pstmt = conn.prepareStatement("DELETE FROM
cloud.distributed_lock WHERE ms_id=?")) {
Review Comment:
TBH - I don't remember but think the release should cleanup when mgmt server
stops. However, upon mgmt server startings we should check/remove any locks
owned by the same mgmt server being restarted to handle edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
