sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969317851
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1139,35 +1140,33 @@ public boolean templateIsDeleteable(long templateId) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_ISO_DETACH, eventDescription =
"detaching ISO", async = true)
- public boolean detachIso(long vmId, boolean forced) {
+ public boolean detachIso(long vmId, Long isoParamId, Boolean...
extraParams) {
Account caller = CallContext.current().getCallingAccount();
Long userId = CallContext.current().getCallingUserId();
- // Verify input parameters
- UserVmVO vmInstanceCheck = _userVmDao.findById(vmId);
- if (vmInstanceCheck == null) {
- throw new InvalidParameterValueException("Unable to find a virtual
machine with id " + vmId);
- }
+ boolean forced = extraParams != null && extraParams.length > 0 ?
extraParams[0] : false;
+ boolean isVirtualRouter = extraParams != null && extraParams.length >
1 ? extraParams[1] : false;
Review Comment:
add comment/javadoc to indicate the expected order of the bool extra params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
