sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969318467
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1178,16 +1177,28 @@ public boolean detachIso(long vmId, boolean forced) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_ISO_ATTACH, eventDescription =
"attaching ISO", async = true)
- public boolean attachIso(long isoId, long vmId, boolean forced) {
+ public boolean attachIso(long isoId, long vmId, Boolean... extraParams) {
Account caller = CallContext.current().getCallingAccount();
Long userId = CallContext.current().getCallingUserId();
+ boolean forced = extraParams != null && extraParams.length > 0 ?
extraParams[0] : false;
+ boolean isVirtualRouter = extraParams != null && extraParams.length >
1 ? extraParams[1] : false;
Review Comment:
add comment/javadoc to indicate the expected order of the bool extra params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
