sureshanaparti commented on PR #10265: URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2623764053
> > > > Thanks! I've just tested the change but it does not seem the quiesce option is present in the "Take Instance volume Snapshot" window. I've tested with local, RBD and NFS on KVM. > > > > > > > > > You are right, I only see it on the take instance snapshot dialog. Can you comment @sureshanaparti ? > > > > > > quiesce option will not available in both VM -> "Take Instance volume Snapshot" & Volume -> "Take Snapshot" dialogs, when the volume response returns quiescevm as false. > > But in this case it is present in Volume -> "Take Snapshot" and VM -> "Take Instance Snapshot" dialogs Both these dialogs are in sync with the quiescevm param in the volume response, shows it when quiescevm param is true. Even when it is set, it fails here: https://github.com/apache/cloudstack/blob/4.19/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java#L496-L498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
