shwstppr commented on code in PR #10135:
URL: https://github.com/apache/cloudstack/pull/10135#discussion_r1929482441


##########
ui/src/config/section/storage.js:
##########
@@ -223,7 +223,7 @@ export default {
           label: 'label.change.offering.for.volume',
           args: ['id', 'diskofferingid', 'size', 'miniops', 'maxiops', 
'automigrate'],
           dataView: true,
-          show: (record, store) => { return ['Allocated', 
'Ready'].includes(record.state) && ['Admin'].includes(store.userInfo.roletype) 
},
+          show: (record, store) => { return ['Allocated', 
'Ready'].includes(record.state) && store.apis.changeOfferingForVolume },

Review Comment:
   @LayonRibeiro sorry if I wasn't clear but I meant that line 220 should 
already take care of API access check now since we've removed the user role 
check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to