LayonRibeiro commented on code in PR #10135:
URL: https://github.com/apache/cloudstack/pull/10135#discussion_r1898666454
##########
ui/src/config/section/storage.js:
##########
@@ -223,7 +223,7 @@ export default {
label: 'label.change.offering.for.volume',
args: ['id', 'diskofferingid', 'size', 'miniops', 'maxiops',
'automigrate'],
dataView: true,
- show: (record, store) => { return ['Allocated',
'Ready'].includes(record.state) && ['Admin'].includes(store.userInfo.roletype)
},
+ show: (record, store) => { return ['Allocated',
'Ready'].includes(record.state) && (['Admin'].includes(store.userInfo.roletype)
|| !!store.apis.changeOfferingForVolume) },
Review Comment:
Hi @DaanHoogland ,
The “!!” operators are no big deal, they are a double negation. I did it to
force the return of a boolean, but I really don't think it makes any difference
in this case
https://stackoverflow.com/questions/10467475/double-negation-in-javascript-what-is-the-purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
