hsato03 opened a new pull request, #9828: URL: https://github.com/apache/cloudstack/pull/9828
### Description Currently, creating templates for `DATADISK` volumes is only possible if they have already been part of a VM and are detached. This behavior has been extended so that the volume does not need to be detached and the template can be created as long as the VM is stopped. Furthermore, the UI allows templates to be created for `ROOT` volumes in the `Allocated` state, however, the creation always results in an error as the volume needs to exist in the primary storage for the template creation to be possible. With the changes, this option is no longer available. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? In the UI, I tried creating a template from a volume in different scenarios: | N° | VM State | Volume Type | Volume State | Could create the template? | | ------ | ------ | ------ | ------ | ------ | | 1 | Stopped | `ROOT` | `Allocated` | No | OK | 2 | Stopped | `ROOT` | `Ready` | Yes | | 3 | Stopped | `DATADISK` | `Ready` | Yes | | 4 | Detached volume | `DATADISK` | `Ready` | Yes | OK | 5 | Running | `ROOT` | `Ready` | No | OK | 6 | Running | `DATADISK` | `Ready` | No | OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
