DaanHoogland commented on code in PR #9628:
URL: https://github.com/apache/cloudstack/pull/9628#discussion_r1743492807
##########
ui/src/views/setting/ConfigurationValue.vue:
##########
@@ -295,7 +299,11 @@ export default {
}
this.$emit('change-config', { value: newValue })
this.$store.dispatch('RefreshFeatures')
- this.$message.success(`${this.$t('label.setting')}
${configrecord.name} ${this.$t('label.reset.config.value')}`)
+ var message = `${this.$t('label.setting')} ${configrecord.name}
${this.$t('label.reset.config.value')}`
+ if (configrecord.isdynamic) {
+ message += `. ${this.$t('message.setting.update.delay')}`
+ }
+ this.$message.success(message)
Review Comment:
this seems like a repeating pattern. Is there any way we can move it to a
generic method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
