abh1sar commented on code in PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#discussion_r1706384171
########## api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java: ########## @@ -82,6 +82,12 @@ public class ListDiskOfferingsCmd extends BaseListProjectAndAccountResourcesCmd since = "4.20.0") private Long virtualMachineId; + @Parameter(name = ApiConstants.FILESHARE, + type = CommandType.BOOLEAN, + description = "Disk offering is meant for File shares", + since = "4.20.0") + private Boolean fileShare; Review Comment: I removed all fileShare specific disk offering code, as we discussed that it is not required. This was missed somehow. I have removed it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org