weizhouapache commented on code in PR #9243: URL: https://github.com/apache/cloudstack/pull/9243#discussion_r1638120109
########## plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java: ########## @@ -2203,7 +2203,7 @@ protected StartAnswer execute(StartCommand cmd) { throw new Exception("Failed to find the newly create or relocated VM. vmName: " + vmInternalCSName); } } - if (deployAsIs) { + if (deployAsIs && !vmMo.hasSnapshot()) { Review Comment: thanks @harikrishna-patnala It looks consistent with this pr. I got the error on vcenter: " Invalid configuration for device '0'. Cannot remove virtual disk from the virtual machine because it or one of its parent disks is part of a snapshot of the virtual machine." it seems to be a known restriction that disk cannot be removed from vm with snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org