DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1562601496
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##########
@@ -93,10 +95,15 @@ public static TemplateObject getTemplate(VMTemplateVO vo,
DataStore store, Strin
}
public void setSize(Long size) {
- imageVO.setSize(size);
+ getImage().setSize(size);
}
public VMTemplateVO getImage() {
+ if (imageVO == null) {
Review Comment:
That is not how it is used in the code I'm afraid. The constructor is called
and next configure is called with the undelying template object. I can move the
exception to the configure call, if we think that makes ore sense.. We'd still
have to guard during the get in case configure was never called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
