DaanHoogland commented on code in PR #8903:
URL: https://github.com/apache/cloudstack/pull/8903#discussion_r1562504691
##########
engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java:
##########
@@ -154,6 +175,28 @@ public boolean updateById(long id, boolean increment, long
delta) {
return update(resourceCountVO.getId(), resourceCountVO);
}
+ @Override
+ public boolean updateCountByDeltaForIds(List<Long> ids, boolean increment,
long delta) {
Review Comment:
would it make sense to remove increment and check for positive/negative
numbers?
the higher level call to `updateResourceCountForAccount` is only done in two
places so it wouldn't be a big refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
