JoaoJandre commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1514463855
##########
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##########
@@ -1223,6 +1228,11 @@ public int expunge(final SearchCriteria<T> sc) {
str.append(sc.getWhereClause());
}
+ if (limit > 0) {
Review Comment:
I see how the index might be beneficial to SELECTs; however, we're only
talking about DELETEs here, do you have any test cases using DELETEs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
