JoaoJandre commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1512752381
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -290,6 +287,11 @@ public String toString() {
protected static ConfigKey<Boolean> vmStatsCollectUserVMOnly = new
ConfigKey<>("Advanced", Boolean.class, "vm.stats.user.vm.only", "false",
"When set to 'false' stats for system VMs will be collected
otherwise stats collection will be done only for user VMs", true);
+ protected static ConfigKey<Long> vmStatsRemoveBatchSize = new
ConfigKey<>("Advanced", Long.class, "vm.stats.remove.batch.size", "0",
"Indicates the" +
Review Comment:
We could have a generic configuration for other operations, that is a good
idea, however, this would incur in a lot more changes that escape this PR's
scope. Furthermore, I don't think that we should reuse
`detail.batch.query.size` for deletion, it is better to have more granularity
on these configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
