DaanHoogland commented on code in PR #7214:
URL: https://github.com/apache/cloudstack/pull/7214#discussion_r1409239364
##########
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:
##########
@@ -318,10 +321,8 @@ protected List<Host> allocateTo(DeploymentPlan plan,
ServiceOffering offering, V
//find number of guest VMs occupying capacity on this host.
if (_capacityMgr.checkIfHostReachMaxGuestLimit(host)) {
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Host name: " + host.getName() + ", hostId:
" + host.getId() +
- " already has max Running VMs(count includes system
VMs), skipping this and trying other available hosts");
- }
+ s_logger.debug(String.format("Adding host [%s] to the avoid
set because this host already has the max number of running (user and/or
system) VMs.",
Review Comment:
> I restrain myself to not ask for extra guards. Please do not remove them
when there. even when upgraded to log4j3 we'll have to remove the
`String.format` calls to prevent the parameterexpansions.
the issue is now how we call the loggers ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
