GaOrtiga commented on code in PR #7214:
URL: https://github.com/apache/cloudstack/pull/7214#discussion_r1489868996
##########
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##########
@@ -1828,6 +1803,75 @@ protected Pair<Map<Volume, List<StoragePool>>,
List<Volume>> findSuitablePoolsFo
return new Pair<Map<Volume, List<StoragePool>>,
List<Volume>>(suitableVolumeStoragePools, readyAndReusedVolumes);
}
+ private boolean
tryToFindPotentialPoolsToAlocateVolume(VirtualMachineProfile vmProfile,
DeploymentPlan plan, ExcludeList avoid, int returnUpTo,
+ Map<Volume, List<StoragePool>> suitableVolumeStoragePools,
VolumeVO toBeCreated, DiskProfile diskProfile) {
+ for (StoragePoolAllocator allocator : _storagePoolAllocators) {
+ s_logger.debug(String.format("Trying to find suitable pools to
allocate volume [%s] necessary to deploy VM [%s], using StoragePoolAllocator:
[%s].",
+ toBeCreated.getUuid(), vmProfile.getUuid(),
allocator.getClass().getSimpleName()));
+
+ final List<StoragePool> suitablePools =
allocator.allocateToPool(diskProfile, vmProfile, plan, avoid, returnUpTo);
+ if (suitablePools != null && !suitablePools.isEmpty()) {
+ s_logger.debug(String.format("StoragePoolAllocator [%s] find
%s suitable pools to allocate volume [%s] necessary to deploy VM [%s].",
Review Comment:
```suggestion
s_logger.debug(String.format("StoragePoolAllocator [%s]
found %s suitable pools to allocate volume [%s] necessary to deploy VM [%s].",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
