DaanHoogland commented on code in PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1484366052
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic,
IPAddressResponse ipResponse
if (!isAdmin) {
return;
}
+ if
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {
Review Comment:
sorry for the late reply @weizhouapache yes and nic as well would have
thrown an NPE before. I think it is not intuitive code but you fix is good and
an improvement on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
