slavkap commented on a change in pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#discussion_r598630234
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##########
@@ -725,7 +725,7 @@ private String getDevLabel(int devId, DiskBus bus, boolean
forIso) {
} else if(devId >= 2) {
devId += 2;
}
- return (DiskBus.SATA == bus) ? "sdb" : "hd" +
getDevLabelSuffix(devId);
+ return (DiskBus.SATA == bus) ? "sd" + getDevLabelSuffix(devId) :
"hd" + getDevLabelSuffix(devId);
Review comment:
And just saw that the second disk is virtio, and it should be SATA also.
I Will add a fix for this, I just need to test it first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
