DaanHoogland commented on a change in pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#discussion_r598571813
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##########
@@ -725,7 +725,7 @@ private String getDevLabel(int devId, DiskBus bus, boolean
forIso) {
} else if(devId >= 2) {
devId += 2;
}
- return (DiskBus.SATA == bus) ? "sdb" : "hd" +
getDevLabelSuffix(devId);
+ return (DiskBus.SATA == bus) ? "sd" + getDevLabelSuffix(devId) :
"hd" + getDevLabelSuffix(devId);
Review comment:
```suggestion
return ((DiskBus.SATA == bus) ? "sd" : "hd") +
getDevLabelSuffix(devId);
```
also, also, are those prefixes really really usniversal across OSses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
