slavkap commented on a change in pull request #4773: URL: https://github.com/apache/cloudstack/pull/4773#discussion_r591454980
########## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ########## @@ -3454,6 +3448,8 @@ public boolean isCentosHost() { return DiskDef.DiskBus.IDE; } else if (platformEmulator.startsWith("Other PV Virtio-SCSI")) { return DiskDef.DiskBus.SCSI; + } else if (isUefiEnabled && platformEmulator.startsWith("Windows")) { + return DiskDef.DiskBus.SATA; Review comment: this is required for both secure/legacy UEFI boot type on Windows machines ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org