[
https://issues.apache.org/jira/browse/CASSANDRA-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714389#comment-13714389
]
Ben Manes commented on CASSANDRA-5661:
--------------------------------------
I replaced the external handle with directly providing the resource and
maintaining the association in a threadlocal. This should better match your
usage and resolve your concern above.
The primary motivation was to reduce object churn, as a handle was created per
borrow. This reduced the hot spot time from an average invocation time of
1001us to 704us, when summing up the worst offenders.
This may remove the random spiked that you observed if they were caused by
garbage collection.
98% of the overhead is now due to usage of other collections (Guava's Cache,
LTQ, CLQ).
> Discard pooled readers for cold data
> ------------------------------------
>
> Key: CASSANDRA-5661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5661
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.1
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 2.0.1
>
> Attachments: CASSANDRA-5661-multiway-per-sstable.patch,
> CASSANDRA-5661.patch, CASSANDRA-5661-v2-global-multiway-per-sstable.patch,
> DominatorTree.png, Histogram.png
>
>
> Reader pooling was introduced in CASSANDRA-4942 but pooled
> RandomAccessReaders are never cleaned up until the SSTableReader is closed.
> So memory use is "the worst case simultaneous RAR we had open for this file,
> forever."
> We should introduce a global limit on how much memory to use for RAR, and
> evict old ones.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
