[
https://issues.apache.org/jira/browse/CASSANDRA-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707990#comment-13707990
]
Ben Manes commented on CASSANDRA-5661:
--------------------------------------
yes, I understand that and that was documented. It was correct to add it early
on, due to prototyping to help catch my bugs if there were race conditions.
When looking at performance then it became appropriate to remove it as tests
have baked the code.
The only aspect I'm grudgingly punting on is that I prefer warning developers
when they have resource leaks, when possible without overhead, instead of
silently letting production environments crash. This can be done with phantom
references, but I dislike having libraries spawn its own threads (e.g. MapMaker
did) and prefer amortizing it (e.g. CacheBuilder). There's no free hook in my
pool to tie into, so I'm not providing that warning given you don't need it atm.
> Discard pooled readers for cold data
> ------------------------------------
>
> Key: CASSANDRA-5661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5661
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.1
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 2.0
>
> Attachments: CASSANDRA-5661-multiway-per-sstable.patch,
> CASSANDRA-5661.patch, CASSANDRA-5661-v2-global-multiway-per-sstable.patch,
> DominatorTree.png, Histogram.png
>
>
> Reader pooling was introduced in CASSANDRA-4942 but pooled
> RandomAccessReaders are never cleaned up until the SSTableReader is closed.
> So memory use is "the worst case simultaneous RAR we had open for this file,
> forever."
> We should introduce a global limit on how much memory to use for RAR, and
> evict old ones.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
