skoppu22 commented on code in PR #206: URL: https://github.com/apache/cassandra-analytics/pull/206#discussion_r3775964852
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/S3ClientConfig.java: ########## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cassandra.spark.data; + +import java.io.Serializable; +import java.util.Map; + +import com.esotericsoftware.kryo.Kryo; +import com.esotericsoftware.kryo.io.Input; +import com.esotericsoftware.kryo.io.Output; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +import org.apache.cassandra.spark.utils.MapUtils; + +/** + * Minimal S3 client configuration for connecting to S3. + * This class contains only the essential settings needed to create an S3 client. + * It is shared across batch and streaming configurations. + */ +public class S3ClientConfig implements Serializable Review Comment: S3ClientConfig carries no encryption identity, and buildS3Client/buildS3AsyncClient hardcode S3Client.builder() / S3AsyncClient.builder() with no injection point. So an org that wants an S3 Encryption Client cannot supply one. getCacheKey hashes only region|endpoint|accessKeyId|secretHash — it has no encryption identity — so a plain client and an encrypting client built for the same bucket/credentials would collide on one cache entry: the first one to be created wins and is silently handed to the other caller -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
