jberragan commented on code in PR #206:
URL: 
https://github.com/apache/cassandra-analytics/pull/206#discussion_r3660966261


##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/DataLayer.java:
##########
@@ -234,6 +235,22 @@ public abstract SSTablesSupplier sstables(int partitionId,
      */
     public abstract String jobId();
 
+    /**
+     * Calculate the total size of all SSTable Data.db files across all 
partitions.
+     * This method provides a default implementation that returns empty. 
Specific DataLayer
+     * implementations should override this method if they have efficient ways 
to
+     * calculate the total size.
+     *
+     * @return OptionalLong containing the total size in bytes of all SSTable 
Data.db files,
+     * or empty if size information is not available
+     */
+    public OptionalLong calculateTotalSSTableSize()

Review Comment:
   There's an existing interface `TableSizeProvider` to help with dynamically 
sizing the spark job, maybe you want to re-use here somehow?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to