[
https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952870#comment-17952870
]
Andy Tolbert commented on CASSANDRA-20328:
------------------------------------------
{quote}
b) when we test something else and executing a tool is just a mean to get there
{quote}
{quote}
We could also make an argument that pulling the tools deps just for tests is
probably OK. Something like "test scoped dependency".
{quote}
(y) Makes sense. If the code is only used from test scope and it's just being
used as a means to validate the core code that sounds reasonable to me.
{quote}
That said, there's an argument to be made that dtests should be treated as a
cross-module test, and either way I don't think it's something to agonise over
extensively. But, personally, I would move the dtest to a module/test/dtest
directory if it weren't overly complicated to do so.
{quote}
A separate module/directory for dtests does sound good to me as well. Maybe
not worth the effort to do on its own, but if there is ever an opportunity to
do some refactoring / reorganization, that could be worth doing long term.
> Migrate sstableloader code to its own tools directory
> -----------------------------------------------------
>
> Key: CASSANDRA-20328
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20328
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Tool/sstable
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
> Labels: pull-request-available
> Fix For: 5.x
>
> Attachments: CASSANDRA-0413-20328_ci_summary.html,
> CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html,
> CASSANDRA-20328-515-0_results_details.tgz, CASSANDRA-20328-test_results.html,
> ci_summary_tolbertam_CASSANDRA-20328_238.html,
> results_details_tolbertam_CASSANDRA-20328_238.tar.xz
>
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Akin to fqltool and stress, we should move sstableloader to its own tools
> directory. This is needed to decouple the java driver as a dependency from
> server code ([CASSANDRA-20326]).
> For backwards compatibility reasons, we should retain {{bin/sstableloader}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
