[ https://issues.apache.org/jira/browse/CASSANDRA-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952630#comment-17952630 ]
Andy Tolbert commented on CASSANDRA-20328: ------------------------------------------ Apologies for the issues, I must have missed porting over these (and maybe more?) dtests. I'll take a look at this. Agree that these tests need to be moved to tools/sstableloader. I need to think about how that might impact running dtests as moving these to a separate path might impact the existing ant targets (i'll look into that). In terms of the cassandra.classpath pulling every jar in build, that's definitely not great (and I suppose would have been an existing problem?). Fortunately none of the tools jars should not get pulled in to the classpath at runtime, but for building and testing it shouldn't be pulled in, maybe I can fix that in CASSANDRA-20329? > Migrate sstableloader code to its own tools directory > ----------------------------------------------------- > > Key: CASSANDRA-20328 > URL: https://issues.apache.org/jira/browse/CASSANDRA-20328 > Project: Apache Cassandra > Issue Type: Improvement > Components: Tool/sstable > Reporter: Andy Tolbert > Assignee: Andy Tolbert > Priority: Normal > Labels: pull-request-available > Fix For: 5.x > > Attachments: CASSANDRA-0413-20328_ci_summary.html, > CASSANDRA-20328-511-0_ci_summary.html, CASSANDRA-20328-515-0_ci_summary.html, > CASSANDRA-20328-test_results.html, > ci_summary_tolbertam_CASSANDRA-20328_238.html, > results_details_tolbertam_CASSANDRA-20328_238.tar.xz > > Time Spent: 15h 10m > Remaining Estimate: 0h > > Akin to fqltool and stress, we should move sstableloader to its own tools > directory. This is needed to decouple the java driver as a dependency from > server code ([CASSANDRA-20326]). > For backwards compatibility reasons, we should retain {{bin/sstableloader}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org