JeetKunDoug commented on code in PR #1378:
URL:
https://github.com/apache/cassandra-spark-connector/pull/1378#discussion_r2060790779
##########
.github/workflows/main.yml:
##########
@@ -16,15 +14,13 @@ jobs:
fail-fast: false
matrix:
scala: [2.12.19, 2.13.13]
- db-version: [3.11.17, 4.0.12, 4.1.4, 5.0-beta1, dse-6.8.44]
+ db-version: [3.11.19, 4.0.17, 4.1.8, 5.0.4, dse-6.8.44]
steps:
- uses: actions/checkout@v4
- - name: ccm pip installation
- uses: BSFishy/pip-action@v1
- with:
- packages:
git+https://github.com/riptano/ccm.git@d74db63d75112908a77b6c80757df9343fdc3338
+ - name: Install ccm via pip
+ run: pip install git+https://github.com/apache/cassandra-ccm.git@trunk
Review Comment:
So why don't we do this - leave it at trunk but document in a comment if CCM
breaks something it's reasonable to pin it to a previous SHA until CCM is
fixed? That way we at least see the breakage but then have the option to
unblock changes here while CCM gets fixed (or we just go fix it, given if it
fails nobody else noticed it was broken in the first place I guess).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
