JeetKunDoug commented on code in PR #1378:
URL:
https://github.com/apache/cassandra-spark-connector/pull/1378#discussion_r2058544802
##########
.github/workflows/main.yml:
##########
@@ -16,15 +14,13 @@ jobs:
fail-fast: false
matrix:
scala: [2.12.19, 2.13.13]
- db-version: [3.11.17, 4.0.12, 4.1.4, 5.0-beta1, dse-6.8.44]
+ db-version: [3.11.19, 4.0.17, 4.1.8, 5.0.4, dse-6.8.44]
steps:
- uses: actions/checkout@v4
- - name: ccm pip installation
- uses: BSFishy/pip-action@v1
- with:
- packages:
git+https://github.com/riptano/ccm.git@d74db63d75112908a77b6c80757df9343fdc3338
+ - name: Install ccm via pip
+ run: pip install git+https://github.com/apache/cassandra-ccm.git@trunk
Review Comment:
Is there a risk of pulling directly from Trunk breaking something if trunk
has some breaking change? Looks like there aren't any tags in the repo to use
but maybe tie to a SHA rather than trunk itself? Or maybe we can start tagging
CCM?
##########
README.md:
##########
@@ -177,7 +177,7 @@ To protect the community, all contributors are required to
sign the Apache Softw
[Tips for Developing the Spark Cassandra Connector](doc/developers.md)
Checklist for contributing changes to the project:
-* Create a [SPARKC
JIRA](https://datastax-oss.atlassian.net/projects/SPARKC/issues)
+* Create a [SPARKC JIRA](https://issues.apache.org/jira/projects/CASSANALYTICS)
Review Comment:
Do we want to add another Jira component before we point folks at
CASSANALYTICS? I suppose we can move things over later, so maybe not a big deal.
##########
doc/developers.md:
##########
@@ -73,11 +73,11 @@ git push origin SPARKC-9999-b3.1
# Repeat for b3.2
Review Comment:
This should be `Repeat for b3.2, b3.3, b3.4`
##########
README.md:
##########
@@ -45,17 +45,17 @@ in your Spark applications.
The connector project has several branches, each of which map into different
supported versions of Spark and Cassandra. For previous releases the branch is
named "bX.Y" where X.Y is the major+minor version; for example the "b1.6"
branch
-corresponds to the 1.6 release. The "master" branch will normally contain
+corresponds to the 1.6 release. The "trunk" branch will normally contain
development for the next connector release in progress.
Currently, the following branches are actively supported:
-3.5.x
([master](https://github.com/datastax/spark-cassandra-connector/tree/master)),
-3.4.x
([b3.4](https://github.com/datastax/spark-cassandra-connector/tree/b3.4)),
-3.3.x
([b3.2](https://github.com/datastax/spark-cassandra-connector/tree/b3.3)),
-3.2.x
([b3.2](https://github.com/datastax/spark-cassandra-connector/tree/b3.2)),
-3.1.x
([b3.1](https://github.com/datastax/spark-cassandra-connector/tree/b3.1)),
-3.0.x
([b3.0](https://github.com/datastax/spark-cassandra-connector/tree/b3.0)) and
-2.5.x
([b2.5](https://github.com/datastax/spark-cassandra-connector/tree/b2.5)).
+3.5.x
([trunk](https://github.com/apache/cassandra-spark-connector/tree/trunk)),
Review Comment:
We should really have a discussion about the number of branches we want to
support given the move from Datastax to Apache - this seems excessive and maybe
unnecessary, but I'm not sure why we currently have this many (Spark and Scala
are sometimes difficult from a compatibility perspective... that said, looking
at the compatibility chart, it seems like we may be able to reduce this down to
3.5.1 and 2.5 if 3.5.1 works on older Spark versions (back to 3.0, which most
libraries _should_ be able to do I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
