yifan-c commented on code in PR #102:
URL: 
https://github.com/apache/cassandra-analytics/pull/102#discussion_r1994136552


##########
cassandra-four-zero-types/src/main/java/org/apache/cassandra/spark/data/types/Duration.java:
##########
@@ -32,8 +46,148 @@ public String name()
     }
 
     @Override
-    public boolean isSupported()
+    public AbstractType<?> dataType()
+    {
+        return DurationType.instance;
+    }
+
+    public <T> TypeSerializer<T> serializer()
+    {
+        return (TypeSerializer<T>) CalendarIntervalSerializer.INSTANCE;

Review Comment:
   ~I think we can continue using `DurationSerializer.instance`.~
   
   _Update_ 
   I tried out `DurationSerializer.instance` and other necessary changes. It 
does not work for nested type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to