yifan-c commented on PR #102: URL: https://github.com/apache/cassandra-analytics/pull/102#issuecomment-2731189520
The changes look good to me. However, the CI link you shared does not open. It gives me 404. Can you double check and shared it at https://issues.apache.org/jira/browse/CASSANALYTICS-18? Re: squashing. You do not need to squash them. For this repo, the convention is to merge from the PR page directly, using the `Squash and merge` button. (There is one single trunk. so why the trouble of the manual work :p) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
