[
https://issues.apache.org/jira/browse/CASSANDRA-18166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789534#comment-17789534
]
Andres de la Peña commented on CASSANDRA-18166:
-----------------------------------------------
{quote}How can we know that the trunk patch isn't introducing new failures,
being based on a different codebase?
{quote}
I meant if we applied "any CI differences after the rebase I would attribute to
TCM and 19055". Of course, the standard pre-commit procedure should be able to
deal with this. We just get all the test failures on the candidate patch and
subtract the well-known issues. Then we start a repeated CI run on unpatched
trunk for the remaining tests, to see if they were broken before. If they were,
we open a separate ticket for them. Any test that can't reproduce on unpatched
trunk can be considered a new failure introduced by the patch, and we have to
fix it before commit. That's what we plan to do here.
> Improve the code model around IndexContext
> ------------------------------------------
>
> Key: CASSANDRA-18166
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18166
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
> Reporter: Mike Adamson
> Assignee: Mike Adamson
> Priority: Normal
> Labels: SAI
> Fix For: 5.0-beta
>
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> We currently have a situation where we need to create an IndexContext that is
> for a non-indexed column and therefore is never going to be used for indexing
> or searching. This results in the IndexContext having to check for this at
> points in the code with assertions. The reason for this that, even when the
> column is non-indexed, we need to have information about the column for the
> purpose of post-filtering.
> It would make sense to split out the column / index information needed for
> filtering from the indexing / searching requirements such that we could avoid
> unnecessary assertions in the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
