[
https://issues.apache.org/jira/browse/CASSANDRA-18166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789491#comment-17789491
]
Andres de la Peña commented on CASSANDRA-18166:
-----------------------------------------------
Changes look good to me. Here is a CI run for 5.0:
*
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3329/workflows/f2124edd-fa0e-4bc5-ab03-ddfb886bf015]
*
[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3329/workflows/998dcba1-0780-4e03-a47f-995d524d0715]
These runs have hit these test failures:
* {{StorageAttachedIndexDDLTest#concurrentTruncateWithIndexBuilding}} is
CASSANDRA-19032
*
[{{IndexStreamingFailureTest#testAvailabilityAfterFailedNonEntireFileStreaming}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/3329/workflows/f2124edd-fa0e-4bc5-ab03-ddfb886bf015/jobs/93097/tests]
doesn't have an associated ticket, but at least one of the failures has been
[hit on
Jenkins|https://ci-cassandra.apache.org/job/Cassandra-5.0/106/testReport/org.apache.cassandra.distributed.test.sai/IndexStreamingFailureTest/testAvailabilityAfterFailedNonEntireFileStreaming__jdk11_x86_64_novnode]
before this patch.
I haven't run CI on trunk, which needs a rebase on top of the extensive changes
recently introduced by CASSANDRA-18330. That ticket has been merged without
clean CI results, so it might be tricky to distinguish what causes what
failures.
> Improve the code model around IndexContext
> ------------------------------------------
>
> Key: CASSANDRA-18166
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18166
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/SAI
> Reporter: Mike Adamson
> Assignee: Mike Adamson
> Priority: Normal
> Labels: SAI
> Fix For: 5.0-beta
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> We currently have a situation where we need to create an IndexContext that is
> for a non-indexed column and therefore is never going to be used for indexing
> or searching. This results in the IndexContext having to check for this at
> points in the code with assertions. The reason for this that, even when the
> column is non-indexed, we need to have information about the column for the
> purpose of post-filtering.
> It would make sense to split out the column / index information needed for
> filtering from the indexing / searching requirements such that we could avoid
> unnecessary assertions in the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
