[ 
https://issues.apache.org/jira/browse/CASSANDRA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777643#comment-17777643
 ] 

Maxim Muzafarov commented on CASSANDRA-18836:
---------------------------------------------

[~maedhroz] [~jasonstack] thank you for the review. I've reviewed the test 
results above and it outlines that I forgot to fix the assertion check in tests 
as the log output was slightly updated. The new results are below:


5.0:
https://github.com/apache/cassandra/pull/2782
https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/453/workflows/472779e6-d904-4f19-b920-789f91225073

trunk:
https://github.com/apache/cassandra/pull/2687
https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/450/workflows/51f51b0f-4d4a-4d08-a503-10249e6423fa


> Replace CRC32 w/ CRC32C in IndexFileUtils.ChecksummingWriter
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-18836
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18836
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/2i Index, Feature/SAI
>            Reporter: Caleb Rackliffe
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0-alpha2, 5.x
>
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> It seems that now we're on Java 11 for 5.0, there isn't much reason not to 
> use CRC32C as a drop-in replacement for CRC32. SAI isn't even released, so 
> has no binary compatibility entanglements, and this should be pretty 
> straightforward.
> See https://github.com/apache/bookkeeper/pull/3309



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to