[
https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775889#comment-17775889
]
Ariel Weisberg commented on CASSANDRA-18799:
--------------------------------------------
We were apparently still on a version of OHC from 2016? There are some
significant changes mixed in there
https://github.com/snazy/ohc/compare/0.5.1...0.7.4
I checked out OHC and `UnsTest` fails with an unsafe memory access in
`testDecrementIncrement`, and it is in the linked implementation which I
believe we use in Cassandra. It seems like it fails all the way back to JDK 8.
I haven't figured out yet why that is the case and this is an increment
function that is actually in use.
The changes are pretty substantial in terms of there being a lot of refactoring
to allow for multiple eviction policies. Previously I think there was just LRU.
There was also a lot of testing added, but we should expect this to potentially
be a major change and we don't test with row cache or test with validating
workloads like simulator.
Ideally we would test this with simulator and have simulator inject some chaos
into eviction so that we can force the eviction policies to evict things with
some distribution determined by simulator.
[~snazy] if you don't want to do releases and merge PRs for OHC can you
contribute to ASF so we can fork it? In the interim can you add some
collaborators to the repo and someone to publish jars to maven?
> Remove org.caffinitas.ohc:ohc-core-j8 dependency
> ------------------------------------------------
>
> Key: CASSANDRA-18799
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18799
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the
> Cassandra project moved away from JDK8 support. The changes are here:
> CASSANDRA-18255
> We can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
