[ 
https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771002#comment-17771002
 ] 

Berenguer Blasi commented on CASSANDRA-18799:
---------------------------------------------

I don't have the deep knowledge others have on OHC but as far as I could review 
all LGTM +1:
- The j8 specific dep has been removed
- The new dep covers for that on the new upgraded version
- Changelog has been observed
- CI so far is green and failures can be matched to existing tickets

I'm only a bit confused the conversation mentions CI runs several times but 
they all point to the same exact one. Iiuc these are just different parts being 
ran at different times and now full pre-commit trunk and 5.0 will come with a 
rebase?

#collaborating

> Remove org.caffinitas.ohc:ohc-core-j8 dependency
> ------------------------------------------------
>
>                 Key: CASSANDRA-18799
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18799
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0.x, 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the 
> Cassandra project moved away from JDK8 support. The changes are here: 
> CASSANDRA-18255
> We can remove it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to