[ 
https://issues.apache.org/jira/browse/CASSANDRA-18255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745146#comment-17745146
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18255:
-------------------------------------------------

PR opened - [https://github.com/apache/cassandra/pull/2503]
{quote} - J17 failures align to CASSANDRA-16895
 - Upgrade test failures align to CASSANDRA-18499
 - The rest are timeouts{quote}
Yes, yes, and yes :)
{quote}agree with Jeremiah's comment
{quote}
Addressed here - 
[https://github.com/riptano/ccm/commit/03e7959904ff7017f1b4f9b83e69840bed2db873]
{quote} - You could leave 
[this|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18255-trunk#diff-d840184ab2700b185c61c68d7be79c51ce64a3285f5114f76112c8c98f8aff6fL53];
 it doesn't seem to hurt imo{quote}
[~mck] ? The to-do was left from you. Also, just confirming, did you or anyone 
else try to run the new scripts from CASSANDRA-18133 to verify that I didn't 
break anything? I asked last night in Slack, but I am not sure whether anyone 
had the chance to do it, so confirming. 
{quote} - You don't want to mention j17 is still experimental 
[here|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18255-trunk#diff-bac3a4a2bbeacb51b8f29f5dffbadbfc89f5960f84c0656e6c94c3e1d83a3442]
 for 5.0, or is my understanding incorrect?{quote}
This is the CircleCI readme, so experimental in this case referred to the 
temporary second CI config for 11+17, which was added for test purposes and now 
became a primary one. I updated the readme accordingly.
{quote} - I miss CHANGES and upgrade notes, although I know many people prefer 
to do it just right before the commit.{quote}
Correct, those will be added at the end. 
{quote} - Some extra spaces 
[here|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18255-trunk#diff-9405c8896ec20e5e91399a71f450251c8da83d336df2d3a00c66d6c914ca05b4R310]{quote}
[https://github.com/apache/cassandra/commit/eafcfc46b261c71a5f544ff37f3b7ced656cb3de]
{quote}(1) Cassandra-builds patch is +1 from me
{quote}
The patch only addresses the test runs, not the builds; we don't need to 
package any more JDK8 builds. I will look into that.

 

 

> Drop JDK8 Support
> -----------------
>
>                 Key: CASSANDRA-18255
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18255
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Michael Semb Wever
>            Assignee: Ekaterina Dimitrova
>            Priority: High
>             Fix For: 5.x
>
>
> * update Jenkins builds scripts (Cassandra-builds) for trunk to build and run 
> tests only with JDK 11 and JDK 17 - both Jenkins-dev and post-commit
>  * the JDK11+17 config files and script in cassandra/.circleci should replace 
> the default J8+J11 test config files and script
>  * Cassandra trunk build.xml and conf files should be updated - JDK8 removed 
> everywhere
>  * Any tickets blocked on this one and ready to commit should be committed
>  * Revert this change in CCM - 
> [https://github.com/riptano/ccm/commit/6e71061146f7ae67b84ccd2b1d90d7319b640e4c#diff-0999a90fd83b66b6840af0bbd8afd1ebd9648e135b0665692fa0f523325a1058L984]
>  * Docs will be updated later in CASSANDRA-18233
> NOTE: Python Upgrade tests were already switched to 11 in this 
> [change|https://github.com/apache/cassandra-dtest/commit/52053200e75d3e6718c03bfa68232dfb94f9a566#diff-31d0989c90471274d54ccce871e5ea977ba477d1b55ee13be6f399fd844c16cfR171],
>  so I _think_ there is no other change pending in cassandra-dtest repo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to