[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744694#comment-17744694
]
Maxim Muzafarov commented on CASSANDRA-14667:
---------------------------------------------
[~e.dimitrova] , [~smiklosovic]
I have analysed the test results and found that copying JmxReporter (and
associated classes) as I suggested earlier is not sufficient and only covers
the subset of the problems. The following tools use the driver and in turn,
initialise the Cassandra's Dwopwizard library is upgraded to 4.x:
- BulkLoader (NativeSSTableLoaderClient)
- FQLQueryLogTool (QueryReplayer)
- Stress (JavaDriverClient) - already have withoutMetrics()
https://github.com/jasonwee/cassandra/commit/0d0acac6c59d3fa703a3d504f9cfd063e4d111b7
So, the complete solution is to use withoutMetrics() for the other tools as
well. This should be safe as these tools by themselves are not designed to
fetch the metrics. The PR was updated accordingly.
Although we can move forward with the patch, I still have some concerns for
users who want to use the 3.x java-driver with Cassandra 5.x and are likely to
encounter the same (if the patch is accepted). To remove these concerns I have
prepared a small patch to the cassandra-java-driver project that includes the
dropwizard metrics as shaded classes into the jar (the approach is similar to
the netty). The patch is here and of the 3.x only:
https://github.com/datastax/java-driver/pull/1685
I have tested locally, so it works without the `withoutMetrics()` or copying
the JMXReporter classes like a charm. I haven't tested it in the CI. In this
case the plan might be:
- release java-driver 3.11.4
- update the cassandra's dependency up to 3.11.4
- upgrade the dropwziard metrics library to 4.2.19 without doing anything else;
The problem here is that the 3.x driver is likely to become obsolete alongside
the 5.x release, as the release policy [1] only supports 2 LTS releases. This
may not be related to the driver itself, and it may live on for a while and if
so it is worth considering to release 3.11.4 as the changes are related to the
driver build only.
WDYT?
[1]
https://cwiki.apache.org/confluence/display/CASSANDRA/Patching%2C+versioning%2C+and+LTS+releases
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
