[ 
https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738979#comment-17738979
 ] 

Stefan Miklosovic commented on CASSANDRA-18438:
-----------------------------------------------

[~maxwellguo] this is default snitch (1). Then, as AlibabaSnitch is basically 
nothing but (1) with some URL, we can do this (2)

(1) 
https://github.com/apache/cassandra/pull/2458/commits/3069fc8a7e9c21e9e348780a8b3d712b5c256b83#diff-a70c5f29150c652b72071f6b5cf3a45bdae621695c7a9f42959a61bf47ff6615
(2) 
https://github.com/apache/cassandra/pull/2458/commits/eb69634b6ed92ba7f770809b4be74757f5d61539#diff-1c0c3a72dd4fbf4aabf1b00394d64f91d6262f732e4cb9984c3239223ca59fe4


> Refactor the code for public cloud platform snitch to be configurable
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-18438
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18438
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Other
>            Reporter: Maxwell Guo
>            Assignee: Maxwell Guo
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Nowadays we have got about four public cloud platform snitchs : EC2 snitch 
> for aws, google cloud snitch for google cloud, alibaba cloud snitch for 
> alibaba cloud and multi region snitch for ec2. And the common place for the 
> first three is that we just need to query the zone center to get the ec2 / 
> ecs id , so I think we can refactor the code , and  if some new public cloud 
> platform want to add one more snitch for himself, there is no need to pull a 
> pr for him and  configure some options in yaml is enough .
> Besides it would be even better that we may reuse the multic region snitch 
> for ec2 for other public cloud platform.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to