[
https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738857#comment-17738857
]
Maxwell Guo commented on CASSANDRA-18438:
-----------------------------------------
Thanks [~smiklosovic].
-> "I think that this approach is good enough in not repeating the same logic
but flexible enough to implement something custom if necessary."
So far ,I agree with the above point of view. If this also can met [~xgerman42]
's requirement , then I think it’s ok. If I encounter other needs in the
future, I can open jira and do it again.
Besides , I have a point that I want to discuss with you. There is a difference
between the old version and the new version in the meta center of ec2, but the
other two cloud platforms I see are similar. If Azure is the same(only need a a
meta center url ), then can we template this similar in the future, configure
the cloud platform name url center is enough and in the property file, and
there is no need to customize the snitch code to implement some new snitch
class besides we can re-use the ec2multiregion snitch if other cloud platform
only need to provide public and private ip center url (as I know this feature
is need for most users). Of course, there will be several problems in this way
the firs is compatibility, but as I said before , if I encounter more needs, I
may be inclined to do like this.
> Refactor the code for public cloud platform snitch to be configurable
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-18438
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18438
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
> Reporter: Maxwell Guo
> Assignee: Maxwell Guo
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Nowadays we have got about four public cloud platform snitchs ： EC2 snitch
> for aws, google cloud snitch for google cloud, alibaba cloud snitch for
> alibaba cloud and multi region snitch for ec2. And the common place for the
> first three is that we just need to query the zone center to get the ec2 /
> ecs id , so I think we can refactor the code , and if some new public cloud
> platform want to add one more snitch for himself, there is no need to pull a
> pr for him and configure some options in yaml is enough .
> Besides it would be even better that we may reuse the multic region snitch
> for ec2 for other public cloud platform.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
