[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698960#comment-17698960
]
Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/10/23 2:52 PM:
--------------------------------------------------------------------------
{quote}back down to 1448 tests
{quote}
Looks good to me, also correct JDK version from a quick look.
I don't think we should rerun other tests as the change that was affecting the
upgrade tests in the DTest repo (the bump 4.2 to 5.0) was affecting only
upgrade tests.
With this IMHO we can commit in the following order:
1) CCM patch + retag after that so that CI can pick up the latest commits
2) DTest patch
3) Cassandra patch (CASSANDRA-18293)
And with that we can close both this ticket and CASSANDRA-18293.
My suggestion is to send a message to the community to put on pause any commits
until those 3 are in to prevent any conflicts and confusion. WDYT?
Of course, all this said in case [~mck] being also a reviewer is still +1 after
the latest runs/changes
was (Author: e.dimitrova):
{quote}back down to 1448 tests
{quote}
Looks good to me, also correct JDK version from a quick look.
I don't think we should rerun other tests as the change that was affecting the
upgrade tests in the DTest repo (the bump 4.2 to 5.0) was affecting only
upgrade tests.
With this IMHO we can commit in the following order:
1) CCM patch + retag after that so that CI can pick up the latest commits
2) DTest patch
3) Cassandra patch (CASSANDRA-18293)
And with that we can close both this ticket and CASSANDRA-18293.
My suggestion is to send a message to the community to put on pause any commits
until those 3 are in to prevent any conflicts and confusion. WDYT?
Of course, all this said in case [~mck] is still +1 after the latest
runs/changes
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
