[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696122#comment-17696122
]
Michael Semb Wever edited comment on CASSANDRA-18106 at 3/3/23 12:13 PM:
-------------------------------------------------------------------------
And separately, back to…
bq. CASSANDRA-18293 is targeting them in the circle config where they do have
effect; I would remove them as part of CASSANDRA-17869, or even another ticket
since that's going to require a docker push.
I've tested and confirmed that ci-cassandra.a.o needs and works without the
JAVAX_HOME envs set. That is, jdks 8, 11, and 17 all work. (Note these scripts
don't support compiling with one jdk and then running with a higher.)
Furthermore, we can work around the docker push by unsetting those envs in
{{cassandra-dtest-pytest.sh}} like
[this|https://github.com/thelastpickle/cassandra-builds/commit/66a8484059561a7381ae829b4a39a52fb9104ccc].
was (Author: michaelsembwever):
And separately, back to…
bq. CASSANDRA-18293 is targeting them in the circle config where they do have
effect; I would remove them as part of CASSANDRA-17869, or even another ticket
since that's going to require a docker push.
I've tested and confirmed that ci-cassandra.a.o needs and works without the
JAVAX_HOME envs set.
Furthermore, we can work around the docker push by unsetting those envs in
{{cassandra-dtest-pytest.sh}} like
[this|https://github.com/thelastpickle/cassandra-builds/commit/66a8484059561a7381ae829b4a39a52fb9104ccc].
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
