[ 
https://issues.apache.org/jira/browse/CASSANDRA-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601051#comment-17601051
 ] 

David Capwell commented on CASSANDRA-17103:
-------------------------------------------

* accord-core/src/test/java/accord/NetworkFilter.java
accord.NetworkFilter#isMessageType is dead code
* accord-maelstrom/build.gradle  && accord-core/build.gradle
When rebasing on trunk this process got changed, can you move the 1.8 logic to 
buildSrc/src/main/groovy/accord.java-conventions.gradle

Finished pass, overall LGTM I think mostly minor comments... biggest thing I 
think is the apply Future logic

> CEP-15 (C*): Messaging and storage engine integration
> -----------------------------------------------------
>
>                 Key: CASSANDRA-17103
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17103
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Accord
>            Reporter: Benedict Elliott Smith
>            Priority: Normal
>
> This work encompasses implementing Accord’s storage and networking interfaces 
> within Cassandra, so that messages may be sent around the cluster and 
> exectuted



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to