[
https://issues.apache.org/jira/browse/CASSANDRA-17499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520681#comment-17520681
]
Andres de la Peña commented on CASSANDRA-17499:
-----------------------------------------------
[~savni_nagarkar] [~jmckenzie] I've rebased and put the missed call to
{{DatabaseDescriptor.isDaemonInitialized}} into {{{}Guardrails#enabled{}}}, and
now CI looks good to me:
||patch||CI||
|[trunk|https://github.com/adelapena/cassandra/commit/18602aed741277783435ca39ce7049a49f6311cf]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1469/workflows/89da7e71-1f99-49cd-b8dd-dac39dff7279]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1469/workflows/214396e3-b438-403a-a457-7b48e8e8a710]|
I've also deleted the obsolete comments about the global flag that are
mentioned on the PR review.
If these changes and CI results look good to you we can set this as ready to
commit.
> Remove global Guardrails Enable flag
> ------------------------------------
>
> Key: CASSANDRA-17499
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17499
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails
> Reporter: Savni Nagarkar
> Assignee: Savni Nagarkar
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This ticket removes the global Guardrails enable flag. Currently the flag
> turns all Guardrails on and off regardless of the individual setting of the
> guardrail property. This presents a problem for maximum replication factor
> and minimum replication factor configurations which will soon be moved to
> guardrails. Those configurations will always need to be enabled so no
> problems arise as Cassandra users create keyspaces. This ensures all
> Guardrail properties follow the same enable / disable procedure.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
