[
https://issues.apache.org/jira/browse/CASSANDRA-17499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515612#comment-17515612
]
Andres de la Peña commented on CASSANDRA-17499:
-----------------------------------------------
The run above hasn't finished yet but there are already test failures. I think
this is because the removal of {{Guardrails#enabled(ClientState)}} has also
removed the check of {{DatabaseDescriptor.isDaemonInitialized()}} that was in
that method. I think that call should go into
{{Guardrail#enabled(ClientState)}}.
> Remove global Guardrails Enable flag
> ------------------------------------
>
> Key: CASSANDRA-17499
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17499
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails
> Reporter: Savni Nagarkar
> Assignee: Savni Nagarkar
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This ticket removes the global Guardrails enable flag. Currently the flag
> turns all Guardrails on and off regardless of the individual setting of the
> guardrail property. This presents a problem for maximum replication factor
> and minimum replication factor configurations which will soon be moved to
> guardrails. Those configurations will always need to be enabled so no
> problems arise as Cassandra users create keyspaces. This ensures all
> Guardrail properties follow the same enable / disable procedure.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
