[ 
https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060108#comment-16060108
 ] 

Paulo Motta commented on CASSANDRA-10130:
-----------------------------------------

bq.  The squashed and rebased patch is in this branch.

The squashed patch LGTM, you should just need to format the commit message to 
include the reviewers ([format 
here|https://wiki.apache.org/cassandra/HowToContribute#Committing]).

bq. The notice for CHANGES.txt is "Fix management of secondary indexes 
(re)builds (CASSANDRA-10130)", which is quite generic and distant from the 
title of this ticket. Suggestions are welcome.

Perhaps "Improve secondary index (re)build failure and concurrency handling"? 

bq. I ran the final patch on our internal CI. There are not failures for the 
unit tests and the failing dtests are not related to the change.

Great job, ship it! (pending [~sbtourist] final +1) :-)

> Node failure during 2i update after streaming can have incomplete 2i when 
> restarted
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andrés de la Peña
>            Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during 
> MV/2i update can leave received SSTables live when restarted while MV/2i are 
> partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the 
> startup, or at least warn user when the node restarts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to