[ 
https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051990#comment-16051990
 ] 

Sergio Bossa commented on CASSANDRA-10130:
------------------------------------------

bq. Update queryableIndexes only on markIndexBuilt and markIndexRemoved

I think we should preserve the original behaviour; it is not perfect, but 
CASSANDRA-13606 should provide a proper fix.

bq. Remove unnecessary marking of index in need of full rebuild on index 
creation

I do not think that was unnecessary, because `createIndex` could fail due to an 
exception in {{Index#getInitializationTask()}}, hence should be considered as 
failed.

bq. Warn user to run full rebuild after index failure and log failure stack 
trace if present

+1 (but {{logAndMarkIndexesFailed}} seems to have a bug 
[here|https://github.com/pauloricardomg/cassandra/commit/19b6f3c68d1b00895de2d3da5aec54102b44ce9f#diff-3f2c8994c4ff8748c3faf7e70958520dR627])

Other than that, I'm +1 on the latest changes, I think we're almost done :)

> Node failure during 2i update after streaming can have incomplete 2i when 
> restarted
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andrés de la Peña
>            Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during 
> MV/2i update can leave received SSTables live when restarted while MV/2i are 
> partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the 
> startup, or at least warn user when the node restarts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to