[ 
https://issues.apache.org/jira/browse/CASSANDRA-11115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723487#comment-15723487
 ] 

Aleksey Yeschenko commented on CASSANDRA-11115:
-----------------------------------------------

Will wrap up soon, minor nits so far:

1. lib/licenses still has licenses for the removed jars
2. {{AlterKeyspaceStatement}}: disregard the TODO comment there, it's no longer 
valid. Feel free to remove or just don't bother, it'll go away soon
3. {{CompactTables.DefaultNames.defaultPartitionKeyName()}} is no longer needed 
(plus the related constant plus the field)
4. {{LegacyLayout}} has tons of unused imports
5. {{CollectionType}} ‘custome type’ typo
6. a lot of unused methods in {{CompositeType.Builder}} and some in 
{{CompositeType}}, some only used by tests. Assuming from this patch, but could 
be pre-existing.

My oversights from CASSANDRA-12716 review (I think):

7. Unused {{RowIndexEntry.IndexedEntry}} constructor and some minor unused 
things in the class
8. {{ReadResponse}} unused {{command}} field

> Thrift removal
> --------------
>
>                 Key: CASSANDRA-11115
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11115
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 4.0
>
>
> Thrift removal [has been announced for 
> 4.0|http://mail-archives.apache.org/mod_mbox/cassandra-user/201601.mbox/%3ccaldd-zgagnldu3pqbd6wp0jb0x73qjdr9phpxmmo+gq+2e5...@mail.gmail.com%3E].
>  This ticket is meant to serve as a general task for that removal, but also 
> to track issue related to that, either things that we should do in 3.x to 
> make that removal as smooth as possible, or sub-tasks that it makes sense to 
> separate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to