Re: [PR] Add Bundle-Version to all wrapped bundles [camel-karaf]

[via GitHub]

stataru8 commented on code in PR #297:
URL: https://github.com/apache/camel-karaf/pull/297#discussion_r1616244242


##########
features/src/main/feature/camel-features.xml:
##########
@@ -1089,23 +1089,23 @@
         <bundle 
dependency='true'>mvn:com.google.api-client/google-api-client/${google-api-client-version}</bundle>
         <bundle 
dependency='true'>mvn:com.google.http-client/google-http-client-apache-v2/${google-cloud-http-client-version}</bundle>
         <bundle dependency='true'>mvn:org.threeten/threetenbp/1.6.8</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.api/api-common/2.28.0</bundle>
-        <bundle dependency='true'>wrap:mvn:com.google.api/gax/2.45.0</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.api/gax-httpjson/2.45.0</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.apis/google-api-services-storage/v1-rev20240209-2.0.0</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.auth/google-auth-library-credentials/${google-auth-library-oauth2-http-version}</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.auth/google-auth-library-oauth2-http/${google-auth-library-oauth2-http-version}</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.cloud/google-cloud-core/2.35.0</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.cloud/google-cloud-core-http/2.35.0</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.cloud/google-cloud-storage/2.35.0</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.http-client/google-http-client/${google-cloud-http-client-version}$overwrite=merge&amp;Import-Package=com.google.common*;version="[33,34)",*</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.http-client/google-http-client-appengine/${google-cloud-http-client-version}</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.http-client/google-http-client-gson/${google-cloud-http-client-version}</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.http-client/google-http-client-jackson2/${google-cloud-http-client-version}</bundle>
-        <bundle 
dependency='true'>wrap:mvn:com.google.oauth-client/google-oauth-client/${google-oauth-client-version}$overwrite=merge&amp;Import-Package=com.google.common*;version="[33,34)",*</bundle>
-        <bundle 
dependency='true'>wrap:mvn:io.grpc/grpc-api/${grpc-version}</bundle>
-        <bundle 
dependency='true'>wrap:mvn:io.opencensus/opencensus-api/0.31.1</bundle>
-        <bundle 
dependency='true'>wrap:mvn:io.opencensus/opencensus-contrib-http-util/0.31.1</bundle>
+        <bundle 
dependency='true'>wrap:mvn:com.google.api/api-common/2.28.0$Bundle-Version=2.28.0</bundle>
+        <bundle 
dependency='true'>wrap:mvn:com.google.api/gax/2.45.0$Bundle-Version=2.45.0</bundle>
+        <bundle 
dependency='true'>wrap:mvn:com.google.api/gax-httpjson/2.45.0$Bundle-Version=2.45.0</bundle>
+        <bundle 
dependency='true'>wrap:mvn:com.google.apis/google-api-services-storage/v1-rev20240209-2.0.0$Bundle-Version=0.0.0.v1-rev20240209-2_0_0</bundle>

Review Comment:
   yes, I've tested it in karaf 4.4.6 and it's supported



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org