stataru8 commented on code in PR #297:
URL: https://github.com/apache/camel-karaf/pull/297#discussion_r1616263265
##########
features/src/main/feature/camel-features.xml:
##########
@@ -1414,9 +1414,9 @@
<feature name="camel-jq" version="${project.version}" start-level="50">
<feature version='${camel.osgi.version.range}'>camel-core</feature>
<feature version='[2.16,2.17)'>jackson</feature>
- <bundle
dependency='true'>wrap:mvn:net.thisptr/jackson-jq/${jackson-jq-version}$overwrite=merge&Export-Package=net*;version=${jackson-jq-version}</bundle>
- <bundle
dependency='true'>wrap:mvn:org.jruby.jcodings/jcodings/1.0.58</bundle>
- <bundle dependency='true'>wrap:mvn:org.jruby.joni/joni/2.2.1</bundle>
+ <bundle
dependency='true'>wrap:mvn:net.thisptr/jackson-jq/${jackson-jq-version}$overwrite=merge&Bundle-Version=1.0.0.preview_20240207&Export-Package=net*;version=${jackson-jq-version}</bundle>
Review Comment:
The version coming from the version placeholder doesn't work
`<jackson-jq-version>1.0.0-preview.20240207</jackson-jq-version>`
```
karaf@root()> feature:install camel-jq
org.osgi.framework.BundleException: Could not create bundle object.
at org.apache.felix.framework.Felix.installBundle(Felix.java:3339)
at
org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
at
org.eclipse.equinox.internal.region.BundleIdBasedRegion.installBundle0(BundleIdBasedRegion.java:120)
at
org.eclipse.equinox.internal.region.BundleIdBasedRegion.installBundleAtLocation(BundleIdBasedRegion.java:100)
at
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installBundle(BundleInstallSupportImpl.java:135)
at
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installBundle(FeaturesServiceImpl.java:1145)
at
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:906)
at
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1069)
at
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:1004)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.IllegalArgumentException: invalid version
"1.0.0-preview.20240207": non-numeric "0-preview"
at org.osgi.framework.Version.parseInt(Version.java:169)
at org.osgi.framework.Version.<init>(Version.java:134)
at org.osgi.framework.Version.valueOf(Version.java:255)
at org.osgi.framework.Version.parseVersion(Version.java:226)
at
org.apache.felix.framework.util.manifestparser.ManifestParser.<init>(ManifestParser.java:129)
at
org.apache.felix.framework.BundleRevisionImpl.<init>(BundleRevisionImpl.java:117)
at
org.apache.felix.framework.BundleImpl.createRevision(BundleImpl.java:1290)
at org.apache.felix.framework.BundleImpl.<init>(BundleImpl.java:114)
at org.apache.felix.framework.Felix.installBundle(Felix.java:3287)
... 12 more
Caused by: java.lang.NumberFormatException: For input string: "0-preview"
at
java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
at java.base/java.lang.Integer.parseInt(Integer.java:668)
at java.base/java.lang.Integer.parseInt(Integer.java:786)
at org.osgi.framework.Version.parseInt(Version.java:167)
... 20 more
```
##########
features/src/main/feature/camel-features.xml:
##########
@@ -1822,30 +1822,30 @@
<feature version='[2.16,2.17)'>jackson</feature>
<feature version='[33,34)'>guava</feature>
<!-- use wrap to override the guava version -->
- <bundle
dependency='true'>wrap:mvn:com.github.openstack4j.core/openstack4j-core/${openstack4j-version}$overwrite=merge&Import-Package=com.fasterxml*,com.github*,javax*,org*,com.google*;version='[33,34)'</bundle>
- <bundle
dependency='true'>wrap:mvn:com.github.openstack4j.core.connectors/openstack4j-okhttp/${openstack4j-version}$overwrite=merge&Import-Package=com.fasterxml*,okhttp3*,javax*,org*;resolution:=optional,com.google*;version='[33,34)'</bundle>
- <bundle
dependency='true'>wrap:mvn:com.github.java-json-tools/json-patch/${json-patch-version}$overwrite=merge&Export-Package=com.github.fge*;version=${json-patch-version}&Import-Package=com.fasterxml*,com.github*;javax*</bundle>
- <bundle
dependency='true'>wrap:mvn:com.github.java-json-tools/jackson-coreutils/2.0$overwrite=merge&Export-Package=com.github.fge*;version=2.0&Import-Package=com.fasterxml*,com.github*;javax*</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.github.openstack4j.core/openstack4j-core/${openstack4j-version}$overwrite=merge&Bundle-Version=${openstack4j-version}&Import-Package=com.fasterxml*,com.github*,javax*,org*,com.google*;version='[33,34)'</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.github.openstack4j.core.connectors/openstack4j-okhttp/${openstack4j-version}$overwrite=merge&Bundle-Version=${openstack4j-version}&Import-Package=com.fasterxml*,okhttp3*,javax*,org*;resolution:=optional,com.google*;version='[33,34)'</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.github.java-json-tools/json-patch/${json-patch-version}$overwrite=merge&Bundle-Version=${json-patch-version}&Export-Package=com.github.fge*;version=${json-patch-version}&Import-Package=com.fasterxml*,com.github*;javax*</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.github.java-json-tools/jackson-coreutils/2.0$overwrite=merge&Bundle-Version=2.0&Export-Package=com.github.fge*;version=2.0&Import-Package=com.fasterxml*,com.github*;javax*</bundle>
<bundle
dependency='true'>mvn:com.github.java-json-tools/msg-simple/1.2</bundle>
<bundle
dependency='true'>mvn:com.github.java-json-tools/btf/1.3</bundle>
<bundle
dependency='true'>mvn:org.yaml/snakeyaml/${snakeyaml-version}</bundle>
- <bundle
dependency='true'>wrap:mvn:com.squareup.okhttp3/okhttp/${squareup-okhttp-version}</bundle>
- <bundle
dependency='true'>wrap:mvn:com.squareup.okhttp3/logging-interceptor/${squareup-okhttp-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.squareup.okhttp3/okhttp/${squareup-okhttp-version}$Bundle-Version=${squareup-okhttp-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:com.squareup.okhttp3/logging-interceptor/${squareup-okhttp-version}$Bundle-Version=${squareup-okhttp-version}</bundle>
<bundle>mvn:org.apache.camel.karaf/camel-openstack/${project.version}</bundle>
</feature>
<feature name='camel-opentelemetry' version='${project.version}'
start-level='50'>
<feature version='${camel.osgi.version.range}'>camel-core</feature>
<feature version='${camel.osgi.version.range}'>camel-tracing</feature>
- <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-api/${opentelemetry-version}</bundle>
- <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-sdk/${opentelemetry-version}</bundle>
- <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-context/${opentelemetry-version}</bundle>
- <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-semconv/${opentelemetry-alpha-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-api/${opentelemetry-version}$Bundle-Version=${opentelemetry-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-sdk/${opentelemetry-version}$Bundle-Version=${opentelemetry-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-context/${opentelemetry-version}$Bundle-Version=${opentelemetry-version}</bundle>
+ <bundle
dependency='true'>wrap:mvn:io.opentelemetry/opentelemetry-semconv/${opentelemetry-alpha-version}$Bundle-Version=1.23.1.alpha</bundle>
Review Comment:
The version coming from the version placeholder doesn't work
`<opentelemetry-alpha-version>1.23.1-alpha</opentelemetry-alpha-version>`
```
karaf@root()> feature:install camel-opentelemetry
org.osgi.framework.BundleException: Could not create bundle object.
at org.apache.felix.framework.Felix.installBundle(Felix.java:3339)
at
org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:147)
at
org.eclipse.equinox.internal.region.BundleIdBasedRegion.installBundle0(BundleIdBasedRegion.java:120)
at
org.eclipse.equinox.internal.region.BundleIdBasedRegion.installBundleAtLocation(BundleIdBasedRegion.java:100)
at
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installBundle(BundleInstallSupportImpl.java:135)
at
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installBundle(FeaturesServiceImpl.java:1145)
at
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:906)
at
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1069)
at
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:1004)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.IllegalArgumentException: invalid version
"1.23.1-alpha": non-numeric "1-alpha"
at org.osgi.framework.Version.parseInt(Version.java:169)
at org.osgi.framework.Version.<init>(Version.java:134)
at org.osgi.framework.Version.valueOf(Version.java:255)
at org.osgi.framework.Version.parseVersion(Version.java:226)
at
org.apache.felix.framework.util.manifestparser.ManifestParser.<init>(ManifestParser.java:129)
at
org.apache.felix.framework.BundleRevisionImpl.<init>(BundleRevisionImpl.java:117)
at
org.apache.felix.framework.BundleImpl.createRevision(BundleImpl.java:1290)
at org.apache.felix.framework.BundleImpl.<init>(BundleImpl.java:114)
at org.apache.felix.framework.Felix.installBundle(Felix.java:3287)
... 12 more
Caused by: java.lang.NumberFormatException: For input string: "1-alpha"
at
java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
at java.base/java.lang.Integer.parseInt(Integer.java:668)
at java.base/java.lang.Integer.parseInt(Integer.java:786)
at org.osgi.framework.Version.parseInt(Version.java:167)
... 20 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
