squakez commented on code in PR #5488:
URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595292465
##########
pkg/trait/jvm.go:
##########
@@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool,
*TraitCondition, error) {
if e.CamelCatalog == nil {
return false,
NewIntegrationConditionPlatformDisabledCatalogMissing(), nil
}
+
+ if t.Jar == "" && e.IntegrationKit != nil {
+ executableArtifact := e.IntegrationKit.GetExecutableArtifact()
+ if executableArtifact == nil {
+ return false, nil, fmt.Errorf("could not locate any
executable among Integration Kit %s artifacts", e.IntegrationKit.Name)
+ }
+ t.Jar = executableArtifact.Target
Review Comment:
Sure, we can open a separate thread to discuss anything related to this. As
you've said, technically speaking there is no difference between the *managed*
Integrations. The only difference is that these Kits are not built by the
operator, so, it cannot make most of the assumptions around certain aspects
(above all linked to the catalog, see also #5417). All the documentation so far
is on https://camel.apache.org/camel-k/next/running/camel-runtimes.html
BTW, I'm planning to add some more documentation as part of this PR to
explain how the JVM changes can enhance the life of users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
